Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: Source/modules/accessibility/AXSpinButton.cpp

Issue 1175533004: Refactor: Clear m_axObjectCache when AXObject detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added ASSERT Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXSpinButton.h ('k') | Source/modules/accessibility/AXTable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXSpinButton.cpp
diff --git a/Source/modules/accessibility/AXSpinButton.cpp b/Source/modules/accessibility/AXSpinButton.cpp
index a3d3068a25c5f26f2d50144a70c040eb64174b5f..ed9e3b339b2902ad56c61f99a009c03c91e38bb3 100644
--- a/Source/modules/accessibility/AXSpinButton.cpp
+++ b/Source/modules/accessibility/AXSpinButton.cpp
@@ -31,12 +31,12 @@
namespace blink {
-PassRefPtr<AXSpinButton> AXSpinButton::create(AXObjectCacheImpl* axObjectCache)
+PassRefPtr<AXSpinButton> AXSpinButton::create(AXObjectCacheImpl& axObjectCache)
{
return adoptRef(new AXSpinButton(axObjectCache));
}
-AXSpinButton::AXSpinButton(AXObjectCacheImpl* axObjectCache)
+AXSpinButton::AXSpinButton(AXObjectCacheImpl& axObjectCache)
: AXMockObject(axObjectCache)
, m_spinButtonElement(0)
{
@@ -75,12 +75,12 @@ void AXSpinButton::addChildren()
{
m_haveChildren = true;
- AXSpinButtonPart* incrementor = toAXSpinButtonPart(axObjectCache()->getOrCreate(SpinButtonPartRole));
+ AXSpinButtonPart* incrementor = toAXSpinButtonPart(axObjectCache().getOrCreate(SpinButtonPartRole));
incrementor->setIsIncrementor(true);
incrementor->setParent(this);
m_children.append(incrementor);
- AXSpinButtonPart* decrementor = toAXSpinButtonPart(axObjectCache()->getOrCreate(SpinButtonPartRole));
+ AXSpinButtonPart* decrementor = toAXSpinButtonPart(axObjectCache().getOrCreate(SpinButtonPartRole));
decrementor->setIsIncrementor(false);
decrementor->setParent(this);
m_children.append(decrementor);
@@ -97,13 +97,13 @@ void AXSpinButton::step(int amount)
// AXSpinButtonPart
-AXSpinButtonPart::AXSpinButtonPart(AXObjectCacheImpl* axObjectCache)
+AXSpinButtonPart::AXSpinButtonPart(AXObjectCacheImpl& axObjectCache)
: AXMockObject(axObjectCache)
, m_isIncrementor(false)
{
}
-PassRefPtr<AXSpinButtonPart> AXSpinButtonPart::create(AXObjectCacheImpl* axObjectCache)
+PassRefPtr<AXSpinButtonPart> AXSpinButtonPart::create(AXObjectCacheImpl& axObjectCache)
{
return adoptRef(new AXSpinButtonPart(axObjectCache));
}
« no previous file with comments | « Source/modules/accessibility/AXSpinButton.h ('k') | Source/modules/accessibility/AXTable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698