Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1330)

Unified Diff: Source/modules/accessibility/AXMediaControls.h

Issue 1175533004: Refactor: Clear m_axObjectCache when AXObject detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added ASSERT Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXListBoxOption.cpp ('k') | Source/modules/accessibility/AXMediaControls.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXMediaControls.h
diff --git a/Source/modules/accessibility/AXMediaControls.h b/Source/modules/accessibility/AXMediaControls.h
index d584da2463bdb3d3f7cc3dfd58e4caf268163576..4c73d2bbd656406b66ed15e29fd7011c754bd107 100644
--- a/Source/modules/accessibility/AXMediaControls.h
+++ b/Source/modules/accessibility/AXMediaControls.h
@@ -40,7 +40,7 @@ class AXObjectCacheImpl;
class AccessibilityMediaControl : public AXLayoutObject {
public:
- static PassRefPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl*);
+ static PassRefPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl&);
virtual ~AccessibilityMediaControl() { }
virtual AccessibilityRole roleValue() const override;
@@ -50,7 +50,7 @@ public:
virtual String deprecatedHelpText() const override;
protected:
- AccessibilityMediaControl(LayoutObject*, AXObjectCacheImpl*);
+ AccessibilityMediaControl(LayoutObject*, AXObjectCacheImpl&);
MediaControlElementType controlType() const;
virtual bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;
};
@@ -59,7 +59,7 @@ protected:
class AccessibilityMediaTimeline final : public AXSlider {
public:
- static PassRefPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl*);
+ static PassRefPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl&);
virtual ~AccessibilityMediaTimeline() { }
virtual String deprecatedHelpText() const override;
@@ -67,14 +67,14 @@ public:
const AtomicString& getAttribute(const QualifiedName& attribute) const;
private:
- AccessibilityMediaTimeline(LayoutObject*, AXObjectCacheImpl*);
+ AccessibilityMediaTimeline(LayoutObject*, AXObjectCacheImpl&);
};
class AXMediaControlsContainer final : public AccessibilityMediaControl {
public:
- static PassRefPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl*);
+ static PassRefPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl&);
virtual ~AXMediaControlsContainer() { }
virtual AccessibilityRole roleValue() const override { return ToolbarRole; }
@@ -83,7 +83,7 @@ public:
virtual String deprecatedAccessibilityDescription() const override;
private:
- AXMediaControlsContainer(LayoutObject*, AXObjectCacheImpl*);
+ AXMediaControlsContainer(LayoutObject*, AXObjectCacheImpl&);
bool controllingVideoElement() const;
virtual bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;
};
@@ -92,7 +92,7 @@ private:
class AccessibilityMediaTimeDisplay final : public AccessibilityMediaControl {
public:
- static PassRefPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl*);
+ static PassRefPtr<AXObject> create(LayoutObject*, AXObjectCacheImpl&);
virtual ~AccessibilityMediaTimeDisplay() { }
virtual AccessibilityRole roleValue() const override { return StaticTextRole; }
@@ -101,7 +101,7 @@ public:
virtual String deprecatedAccessibilityDescription() const override;
private:
- AccessibilityMediaTimeDisplay(LayoutObject*, AXObjectCacheImpl*);
+ AccessibilityMediaTimeDisplay(LayoutObject*, AXObjectCacheImpl&);
virtual bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;
};
« no previous file with comments | « Source/modules/accessibility/AXListBoxOption.cpp ('k') | Source/modules/accessibility/AXMediaControls.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698