Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: Source/modules/accessibility/AXMediaControls.cpp

Issue 1175533004: Refactor: Clear m_axObjectCache when AXObject detaches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added ASSERT Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXMediaControls.h ('k') | Source/modules/accessibility/AXMenuList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXMediaControls.cpp
diff --git a/Source/modules/accessibility/AXMediaControls.cpp b/Source/modules/accessibility/AXMediaControls.cpp
index e438682276a2cd8304018912f9707c37a89cedb0..6687115bd433e6019d67b6d648b70b72e6418bd9 100644
--- a/Source/modules/accessibility/AXMediaControls.cpp
+++ b/Source/modules/accessibility/AXMediaControls.cpp
@@ -43,12 +43,12 @@ static inline String queryString(WebLocalizedString::Name name)
return Locale::defaultLocale().queryString(name);
}
-AccessibilityMediaControl::AccessibilityMediaControl(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache)
+AccessibilityMediaControl::AccessibilityMediaControl(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
: AXLayoutObject(layoutObject, axObjectCache)
{
}
-PassRefPtr<AXObject> AccessibilityMediaControl::create(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache)
+PassRefPtr<AXObject> AccessibilityMediaControl::create(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
{
ASSERT(layoutObject->node());
@@ -186,12 +186,12 @@ AccessibilityRole AccessibilityMediaControl::roleValue() const
//
// AXMediaControlsContainer
-AXMediaControlsContainer::AXMediaControlsContainer(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache)
+AXMediaControlsContainer::AXMediaControlsContainer(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
: AccessibilityMediaControl(layoutObject, axObjectCache)
{
}
-PassRefPtr<AXObject> AXMediaControlsContainer::create(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache)
+PassRefPtr<AXObject> AXMediaControlsContainer::create(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
{
return adoptRef(new AXMediaControlsContainer(layoutObject, axObjectCache));
}
@@ -221,12 +221,12 @@ static String localizedMediaTimeDescription(float /*time*/)
return String();
}
-AccessibilityMediaTimeline::AccessibilityMediaTimeline(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache)
+AccessibilityMediaTimeline::AccessibilityMediaTimeline(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
: AXSlider(layoutObject, axObjectCache)
{
}
-PassRefPtr<AXObject> AccessibilityMediaTimeline::create(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache)
+PassRefPtr<AXObject> AccessibilityMediaTimeline::create(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
{
return adoptRef(new AccessibilityMediaTimeline(layoutObject, axObjectCache));
}
@@ -249,12 +249,12 @@ String AccessibilityMediaTimeline::deprecatedHelpText() const
//
// AccessibilityMediaTimeDisplay
-AccessibilityMediaTimeDisplay::AccessibilityMediaTimeDisplay(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache)
+AccessibilityMediaTimeDisplay::AccessibilityMediaTimeDisplay(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
: AccessibilityMediaControl(layoutObject, axObjectCache)
{
}
-PassRefPtr<AXObject> AccessibilityMediaTimeDisplay::create(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache)
+PassRefPtr<AXObject> AccessibilityMediaTimeDisplay::create(LayoutObject* layoutObject, AXObjectCacheImpl& axObjectCache)
{
return adoptRef(new AccessibilityMediaTimeDisplay(layoutObject, axObjectCache));
}
« no previous file with comments | « Source/modules/accessibility/AXMediaControls.h ('k') | Source/modules/accessibility/AXMenuList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698