Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 117553003: _XcodeVersion: return CLT version as appropriate (Closed)

Created:
7 years ago by mistydemeo
Modified:
6 years, 12 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

_XcodeVersion: return CLT version as appropriate If Xcode isn't installed passing the CLT version is the next best bet. This ports the CLT version function from Homebrew, and calls it if xcodebuild fails to run. BUG=code.google.com/p/gyp/issues/detail?id=292 r1826

Patch Set 1 #

Patch Set 2 : _XcodeVersion: return CLT version as appropriate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M pylib/gyp/xcode_emulation.py View 1 3 chunks +45 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mistydemeo
This patch cleans up an additional couple of xcodebuild usages in xcode_emulation (refs https://codereview.chromium.org/102733012/). This ...
7 years ago (2013-12-19 16:35:08 UTC) #1
Nico
On 2013/12/19 16:35:08, mistydemeo wrote: > This patch cleans up an additional couple of xcodebuild ...
7 years ago (2013-12-19 17:17:58 UTC) #2
mistydemeo
On 2013/12/19 17:17:58, Nico wrote: > Ok. I'll revert that change for now then, as ...
6 years, 12 months ago (2013-12-24 21:16:29 UTC) #3
Nico
lgtm Try jobs at https://codereview.chromium.org/106293003 , if they come back green I'll land this. (Sorry ...
6 years, 12 months ago (2013-12-26 17:54:42 UTC) #4
Nico
r1826
6 years, 12 months ago (2013-12-26 18:09:23 UTC) #5
mistydemeo
6 years, 12 months ago (2013-12-26 21:24:03 UTC) #6
Message was sent while issue was closed.
Thank you!

Powered by Google App Engine
This is Rietveld 408576698