runtime/vm/assembler_mips.cc - Issue 1175523002: Object pool with support for untagged entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_mips.cc

Issue 1175523002: Object pool with support for untagged entries. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/assembler_mips.cc

diff --git a/runtime/vm/assembler_mips.cc b/runtime/vm/assembler_mips.cc

index ef1857c71d20c77a13a0745ec69f92db92edcece..6544611546e5b914dfcdf0645bd08e87e85d01fb 100644

--- a/runtime/vm/assembler_mips.cc

+++ b/runtime/vm/assembler_mips.cc

@@ -472,7 +472,7 @@ void Assembler::LoadObject(Register rd, const Object& object) {

// Make sure that class CallPattern is able to decode this load from the

// object pool.

const int32_t offset =

- Array::element_offset(object_pool_.FindObject(object, kNotPatchable));

+ ObjectPool::element_offset(object_pool_.FindObject(object));

LoadWordFromPoolOffset(rd, offset - kHeapObjectTag);

}