Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 1175523002: Object pool with support for untagged entries. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_arm.cc
diff --git a/runtime/vm/assembler_arm.cc b/runtime/vm/assembler_arm.cc
index e7c2150a2e49a36f400e11a54187256f4189db3b..7f07fca4100f0af09170f287b9585b358d693ffa 100644
--- a/runtime/vm/assembler_arm.cc
+++ b/runtime/vm/assembler_arm.cc
@@ -1575,7 +1575,7 @@ void Assembler::LoadObject(Register rd, const Object& object, Condition cond) {
// Make sure that class CallPattern is able to decode this load from the
// object pool.
const int32_t offset =
- Array::element_offset(object_pool_.FindObject(object, kNotPatchable));
+ ObjectPool::element_offset(object_pool_.FindObject(object));
LoadWordFromPoolOffset(rd, offset - kHeapObjectTag, cond);
}
}
@@ -2660,8 +2660,9 @@ void Assembler::BranchLinkPatchable(const ExternalLabel* label) {
// to by this code sequence.
// For added code robustness, use 'blx lr' in a patchable sequence and
// use 'blx ip' in a non-patchable sequence (see other BranchLink flavors).
- const int32_t offset =
- Array::element_offset(object_pool_.FindExternalLabel(label, kPatchable));
+ const int32_t offset = ObjectPool::element_offset(
+ object_pool_.
+ FindExternalLabel(label, kPatchable));
srdjan 2015/06/09 21:49:46 Should fit on two instead of three lines.
Florian Schneider 2015/06/10 08:26:17 Done.
LoadWordFromPoolOffset(LR, offset - kHeapObjectTag);
blx(LR); // Use blx instruction so that the return branch prediction works.
}

Powered by Google App Engine
This is Rietveld 408576698