Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(53)

Issue 1175453002: Finalize migration of blink_perf.animation to smoothness.tough_animation_cases (Closed)

Created:
4 years, 10 months ago by alancutter (OOO until 2018)
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Ilya Sherman, rjwright, shans, sullivan
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Finalize migration of blink_perf.animation to smoothness.tough_animation_cases This patch removes blink_perf.animation as the last remaining perf tests have been migrated to src/tools/perf/page_sets/tough_animation_cases as part of the smoothness.tough_animation_cases benchmark, see: https://codereview.chromium.org/1156993002 for migration patch. BUG=490225 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -282 lines) Patch
D PerformanceTests/Animation/mix-blend-mode-animation-difference.html View 1 chunk +0 lines, -61 lines 0 comments Download
D PerformanceTests/Animation/mix-blend-mode-animation-hue.html View 1 chunk +0 lines, -61 lines 0 comments Download
D PerformanceTests/Animation/mix-blend-mode-animation-screen.html View 1 chunk +0 lines, -61 lines 0 comments Download
D PerformanceTests/Animation/mix-blend-mode-propagating-isolation.html View 1 chunk +0 lines, -67 lines 0 comments Download
D PerformanceTests/Animation/resources/framerate.js View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alancutter (OOO until 2018)
4 years, 10 months ago (2015-06-09 08:01:13 UTC) #2
Timothy Loh
On 2015/06/09 08:01:13, alancutter wrote: lgtm
4 years, 10 months ago (2015-06-09 08:01:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175453002/1
4 years, 10 months ago (2015-06-09 08:18:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=196749
4 years, 10 months ago (2015-06-09 09:34:03 UTC) #6
shatch
4 years, 10 months ago (2015-06-09 15:46:45 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1163373006/ by simonhatch@chromium.org.

The reason for reverting is: Speculative revert,
blink_perf.animation/oilpan_gc_times.blink_perf_animation failing

BUG=498264.

Powered by Google App Engine
This is Rietveld 408576698