Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1156993002: Migrate blink_perf.animation mix-blend-mode-* to smoothness.tough_animation_cases (Closed)

Created:
5 years, 7 months ago by alancutter (OOO until 2018)
Modified:
5 years, 6 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate blink_perf.animation mix-blend-mode-* to smoothness.tough_animation_cases This change moves the remaining blink_perf.animation tests to the smoothness.tough_animation_cases benchmark. This changes them from using main thread Javascript to approximate a FPS measurement to using proper telemetry to measure animation performance. BUG=490225 Committed: https://crrev.com/dbfa6951278248b90fe3499a3066cfbf0f0c6e68 Cr-Commit-Position: refs/heads/master@{#331518}

Patch Set 1 #

Patch Set 2 : Bad comma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -1 line) Patch
M tools/perf/page_sets/tough_animation_cases.py View 1 1 chunk +12 lines, -1 line 0 comments Download
A tools/perf/page_sets/tough_animation_cases/mix_blend_mode_animation_difference.html View 1 chunk +45 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/mix_blend_mode_animation_hue.html View 1 chunk +45 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/mix_blend_mode_animation_screen.html View 1 chunk +45 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/mix_blend_mode_propagating_isolation.html View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
alancutter (OOO until 2018)
5 years, 7 months ago (2015-05-26 06:09:44 UTC) #2
alancutter (OOO until 2018)
Submitted Android try run: https://codereview.chromium.org/1159453006
5 years, 7 months ago (2015-05-26 06:15:09 UTC) #3
nednguyen
lgtm If you have problem with smoothness metrics' noises, let me know. We can easily ...
5 years, 6 months ago (2015-05-26 17:01:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1156993002/20001
5 years, 6 months ago (2015-05-27 00:23:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-27 03:05:59 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-05-27 03:06:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dbfa6951278248b90fe3499a3066cfbf0f0c6e68
Cr-Commit-Position: refs/heads/master@{#331518}

Powered by Google App Engine
This is Rietveld 408576698