Issue 1175353002: Make the popup menu animation correct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1175353002: Make the popup menu animation correct (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make the popup menu animation correct This CL wires up the opacity of the popup menu items and teaches the popup menu how to draw its background at the right size. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7498d208af81d4d8243a8e4e74fd3ff692c980ab

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -70 lines)			Patch
M	sky/examples/stocks2/lib/stock_arrow.dart	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/checkbox.dart	View		2 chunks	+10 lines, -10 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/floating_action_button.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/components2/popup_menu.dart	View	1	4 chunks	+23 lines, -36 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/popup_menu_item.dart	View		1 chunk	+9 lines, -5 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/radio.dart	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/box.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/specs/style-guide.md	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 6 months ago (2015-06-11 17:09:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
7498d208af81d4d8243a8e4e74fd3ff692c980ab (presubmit successful).