Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: sky/sdk/lib/framework/components2/popup_menu_item.dart

Issue 1175353002: Make the popup menu animation correct (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: style guide update Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/components2/popup_menu.dart ('k') | sky/sdk/lib/framework/components2/radio.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/components2/popup_menu_item.dart
diff --git a/sky/sdk/lib/framework/components2/popup_menu_item.dart b/sky/sdk/lib/framework/components2/popup_menu_item.dart
index d98e9f4d07b530a2ec3e9a56d09698ee072a03a5..78bb37f47bdc1f064a6f89d321c8f78258dfbd60 100644
--- a/sky/sdk/lib/framework/components2/popup_menu_item.dart
+++ b/sky/sdk/lib/framework/components2/popup_menu_item.dart
@@ -12,11 +12,15 @@ class PopupMenuItem extends Component {
final double opacity;
UINode build() {
- return new Container(
- constraints: const BoxConstraints(minWidth: 112.0),
- padding: const EdgeDims.all(16.0),
- // TODO(abarth): opacity: opacity,
- child: new Flex(children)
+ return new Opacity(
+ opacity: opacity,
+ child: new InkWell(
+ children: [new Container(
+ constraints: const BoxConstraints(minWidth: 112.0),
+ padding: const EdgeDims.all(16.0),
+ child: new Flex(children)
+ )]
+ )
);
}
}
« no previous file with comments | « sky/sdk/lib/framework/components2/popup_menu.dart ('k') | sky/sdk/lib/framework/components2/radio.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698