Clean up the tab animation code

Clean up the tab animation code

Keep only one tab and only one icon animation object. So when
we add more cases we don't expand the class state.

BUG=3541
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175638

[sky, 2013-01-07 16:56:08]

https://codereview.chromium.org/11753021/diff/1/chrome/browser/ui/views/tabs/...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/11753021/diff/1/chrome/browser/ui/views/tabs/...
chrome/browser/ui/views/tabs/tab.cc:1528: icon_animation_->Stop();
I don't think we need the Stop() here anymore (since you always create a new
animation).

https://codereview.chromium.org/11753021/diff/1/chrome/browser/ui/views/tabs/...
chrome/browser/ui/views/tabs/tab.cc:1535: icon_animation_->Stop();
Do you need the stop here anymore?

[cpu_(ooo_6.6-7.5), 2013-01-08 01:19:59]

changes made please take a look again.

https://codereview.chromium.org/11753021/diff/1/chrome/browser/ui/views/tabs/...
File chrome/browser/ui/views/tabs/tab.cc (right):

https://codereview.chromium.org/11753021/diff/1/chrome/browser/ui/views/tabs/...
chrome/browser/ui/views/tabs/tab.cc:1528: icon_animation_->Stop();
On 2013/01/07 16:56:08, sky wrote:
> I don't think we need the Stop() here anymore (since you always create a new
> animation).

Done.

https://codereview.chromium.org/11753021/diff/1/chrome/browser/ui/views/tabs/...
chrome/browser/ui/views/tabs/tab.cc:1535: icon_animation_->Stop();
On 2013/01/07 16:56:08, sky wrote:
> Do you need the stop here anymore?

Done.

[sky, 2013-01-08 01:22:24]

LGTM