Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8568)

Unified Diff: chrome/browser/ui/views/tabs/tab.h

Issue 11753021: Clean up the tab animation code (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab.h
===================================================================
--- chrome/browser/ui/views/tabs/tab.h (revision 175095)
+++ chrome/browser/ui/views/tabs/tab.h (working copy)
@@ -235,10 +235,12 @@
void DisplayCrashedFavicon();
void ResetCrashedFavicon();
- // Starts/Stops the crash animation.
void StartCrashAnimation();
void StopCrashAnimation();
+ void StartRecordingAnimation();
+ void StopRecordingAnimation();
+
// Returns true if the crash animation is currently running.
bool IsPerformingCrashAnimation() const;
@@ -287,15 +289,12 @@
bool should_display_crashed_favicon_;
- // Pulse animation. Non-null if StartPulse has been invoked.
- scoped_ptr<ui::ThrobAnimation> pulse_animation_;
+ // The tab and the icon can both be animating. The tab 'throbs' by changing
+ // color. The icon can have one of several of animations like crashing,
+ // recording, projecting, etc.
+ scoped_ptr<ui::ThrobAnimation> tab_animation_;
+ scoped_ptr<ui::LinearAnimation> icon_animation_;
- // Crash animation.
- scoped_ptr<FaviconCrashAnimation> crash_animation_;
-
- // Recording animation.
- scoped_ptr<ui::ThrobAnimation> recording_animation_;
-
scoped_refptr<ui::AnimationContainer> animation_container_;
views::ImageButton* close_button_;
« no previous file with comments | « no previous file | chrome/browser/ui/views/tabs/tab.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698