Invert the owning relationship between WebFrame and Frame.

Source/web/tests/WebFrameTest.cpp

Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index aace67b619f3babbc3f15d3e2f6dd6cfc7154905..56e1f9e9cfdf7c46f86441dead0616da10e76ba0 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -3190,7 +3190,7 @@ TEST_F(WebFrameTest, FindOnDetachedFrame)
     WebFindOptions options;
     WebString searchText = WebString::fromUTF8(kFindString);
     WebFrameImpl* mainFrame = toWebFrameImpl(webViewHelper.webView()->mainFrame());
-    WebFrameImpl* secondFrame = toWebFrameImpl(mainFrame->traverseNext(false));
+    RefPtr<WebFrameImpl> secondFrame = toWebFrameImpl(mainFrame->traverseNext(false));
     RefPtr<WebCore::Frame> holdSecondFrame = secondFrame->frame();

[eseidel, 2013/12/28 01:18:40]

Doesn't secondFrame above hold this reference?

[dcheng, 2013/12/28 01:51:05]

Logically, the embedder holds a reference to it, but we only want to expose
create()/close() semantics to the embedder (this was suggested by darin@, to
model the way WebView works).

The embedder releases this reference by calling close() when Blink tells it
to--e.g. the page is being navigated away from, or the frame was removed from
the DOM. At that point, the embedder releases its reference by calling close().
Typically, this will destroy the WebFrame since there will be no remaining
references.

In this somewhat artificial test, we have to force the WebFrame to remain alive
after line 3197 by manually retaining a reference to it.

 
     // Detach the frame before finding.