Invert the owning relationship between WebFrame and Frame.

Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 3172 matching lines @@
     webViewHelper.webView()->resize(WebSize(640, 480));
     webViewHelper.webView()->layout();
     runPendingTasks();
 
     static const char* kFindString = "result";
     static const int kFindIdentifier = 12345;
 
     WebFindOptions options;
     WebString searchText = WebString::fromUTF8(kFindString);
     WebFrameImpl* mainFrame = toWebFrameImpl(webViewHelper.webView()->mainFrame());
-    WebFrameImpl* secondFrame = toWebFrameImpl(mainFrame->traverseNext(false));
+    RefPtr<WebFrameImpl> secondFrame = toWebFrameImpl(mainFrame->traverseNext(false));
     RefPtr<WebCore::Frame> holdSecondFrame = secondFrame->frame();

[eseidel, 2013/12/28 01:18:40]

Doesn't secondFrame above hold this reference?

[dcheng, 2013/12/28 01:51:05]

Logically, the embedder holds a reference to it, but we only want to expose
create()/close() semantics to the embedder (this was suggested by darin@, to
model the way WebView works).

The embedder releases this reference by calling close() when Blink tells it
to--e.g. the page is being navigated away from, or the frame was removed from
the DOM. At that point, the embedder releases its reference by calling close().
Typically, this will destroy the WebFrame since there will be no remaining
references.

In this somewhat artificial test, we have to force the WebFrame to remain alive
after line 3197 by manually retaining a reference to it.

 
     // Detach the frame before finding.
     EXPECT_TRUE(mainFrame->document().getElementById("frame").remove());
 
     EXPECT_TRUE(mainFrame->find(kFindIdentifier, searchText, options, false, 0));
     EXPECT_FALSE(secondFrame->find(kFindIdentifier, searchText, options, false, 0));
 
     runPendingTasks();
     EXPECT_FALSE(client.findResultsAreReady());
 
@@ skipping 1699 matching lines @@
 
     Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests();
 
     // After commit, there is.
     WebHistoryItem item = frame->currentHistoryItem();
     ASSERT_FALSE(item.isNull());
     EXPECT_EQ(url, item.urlString().utf8());
 }
 
 } // namespace