Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 11748034: Browser Plugin: Refactor BrowserPluginEmbedder to allow creating guests with openers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 76fb13a1c0cdbe68f1c18811f931af0394afb08e..a5103a512bdf7c4b0cb747e8812302528f1b113e 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -390,10 +390,13 @@ WebContentsImpl* WebContentsImpl::CreateWithOpener(
WebContentsImpl* WebContentsImpl::CreateGuest(
BrowserContext* browser_context,
SiteInstance* site_instance,
+ int routing_id,
+ WebContentsImpl* opener_web_contents,
int guest_instance_id,
const BrowserPluginHostMsg_CreateGuest_Params& params) {
- WebContentsImpl* new_contents = new WebContentsImpl(browser_context, NULL);
+ WebContentsImpl* new_contents = new WebContentsImpl(browser_context,
+ opener_web_contents);
// This makes |new_contents| act as a guest.
// For more info, see comment above class BrowserPluginGuest.
@@ -403,7 +406,9 @@ WebContentsImpl* WebContentsImpl::CreateGuest(
new_contents,
params));
- new_contents->Init(WebContents::CreateParams(browser_context, site_instance));
+ WebContents::CreateParams create_params(browser_context, site_instance);
+ create_params.routing_id = routing_id;
+ new_contents->Init(create_params);
return new_contents;
}
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698