Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 11748034: Browser Plugin: Refactor BrowserPluginEmbedder to allow creating guests with openers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed nits Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 WebContentsImpl* new_contents = new WebContentsImpl( 383 WebContentsImpl* new_contents = new WebContentsImpl(
384 params.browser_context, opener); 384 params.browser_context, opener);
385 385
386 new_contents->Init(params); 386 new_contents->Init(params);
387 return new_contents; 387 return new_contents;
388 } 388 }
389 389
390 WebContentsImpl* WebContentsImpl::CreateGuest( 390 WebContentsImpl* WebContentsImpl::CreateGuest(
391 BrowserContext* browser_context, 391 BrowserContext* browser_context,
392 SiteInstance* site_instance, 392 SiteInstance* site_instance,
393 int routing_id,
394 WebContentsImpl* opener_web_contents,
393 int guest_instance_id, 395 int guest_instance_id,
394 const BrowserPluginHostMsg_CreateGuest_Params& params) { 396 const BrowserPluginHostMsg_CreateGuest_Params& params) {
395 397
396 WebContentsImpl* new_contents = new WebContentsImpl(browser_context, NULL); 398 WebContentsImpl* new_contents = new WebContentsImpl(browser_context,
399 opener_web_contents);
397 400
398 // This makes |new_contents| act as a guest. 401 // This makes |new_contents| act as a guest.
399 // For more info, see comment above class BrowserPluginGuest. 402 // For more info, see comment above class BrowserPluginGuest.
400 new_contents->browser_plugin_guest_.reset( 403 new_contents->browser_plugin_guest_.reset(
401 BrowserPluginGuest::Create( 404 BrowserPluginGuest::Create(
402 guest_instance_id, 405 guest_instance_id,
403 new_contents, 406 new_contents,
404 params)); 407 params));
405 408
406 new_contents->Init(WebContents::CreateParams(browser_context, site_instance)); 409 WebContents::CreateParams create_params(browser_context, site_instance);
410 create_params.routing_id = routing_id;
411 new_contents->Init(create_params);
407 412
408 return new_contents; 413 return new_contents;
409 } 414 }
410 415
411 WebPreferences WebContentsImpl::GetWebkitPrefs(RenderViewHost* rvh, 416 WebPreferences WebContentsImpl::GetWebkitPrefs(RenderViewHost* rvh,
412 const GURL& url) { 417 const GURL& url) {
413 WebPreferences prefs; 418 WebPreferences prefs;
414 419
415 const CommandLine& command_line = *CommandLine::ForCurrentProcess(); 420 const CommandLine& command_line = *CommandLine::ForCurrentProcess();
416 421
(...skipping 2972 matching lines...) Expand 10 before | Expand all | Expand 10 after
3389 3394
3390 BrowserPluginGuest* WebContentsImpl::GetBrowserPluginGuest() { 3395 BrowserPluginGuest* WebContentsImpl::GetBrowserPluginGuest() {
3391 return browser_plugin_guest_.get(); 3396 return browser_plugin_guest_.get();
3392 } 3397 }
3393 3398
3394 BrowserPluginEmbedder* WebContentsImpl::GetBrowserPluginEmbedder() { 3399 BrowserPluginEmbedder* WebContentsImpl::GetBrowserPluginEmbedder() {
3395 return browser_plugin_embedder_.get(); 3400 return browser_plugin_embedder_.get();
3396 } 3401 }
3397 3402
3398 } // namespace content 3403 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698