content/browser/web_contents/web_contents_impl.h - Issue 11748034: Browser Plugin: Refactor BrowserPluginEmbedder to allow creating guests with openers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 11748034: Browser Plugin: Refactor BrowserPluginEmbedder to allow creating guests with openers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/browser_plugin/browser_plugin_embedder.cc ('K') | « content/browser/browser_plugin/browser_plugin_embedder.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index e99083772e098fdbcec65a6313df8fe88f57e1d8..6a09cf977015fbd85557cbfb6d9c2e3d492c6dfa 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -85,10 +85,15 @@ class CONTENT_EXPORT WebContentsImpl

const WebContents::CreateParams& params,

WebContentsImpl* opener);

+ // Returns the opener WebContentsImpl.

Charlie Reis 2013/01/04 18:53:19 If we're making this accessible, let's say a littl

Fady Samuel 2013/01/08 17:00:49 Done.

+ WebContentsImpl* opener() const { return opener_; }

// Creates a WebContents to be used as a browser plugin guest.

static WebContentsImpl* CreateGuest(

BrowserContext* browser_context,

content::SiteInstance* site_instance,

+ int routing_id,

+ WebContentsImpl* base_web_contents,

Charlie Reis 2013/01/04 18:53:19 Please call this opener_web_contents.

Fady Samuel 2013/01/08 17:00:49 Done.

int guest_instance_id,

const BrowserPluginHostMsg_CreateGuest_Params& params);