Browser Plugin: Refactor BrowserPluginEmbedder to allow creating guests with openers

content/browser/web_contents/web_contents_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 67 matching lines @@
       public RenderWidgetHostDelegate,
       public RenderViewHostManager::Delegate,
       public NotificationObserver {
  public:
   virtual ~WebContentsImpl();
 
   static WebContentsImpl* CreateWithOpener(
       const WebContents::CreateParams& params,
       WebContentsImpl* opener);
 
+  // Returns the opener WebContentsImpl.

[Charlie Reis, 2013/01/04 18:53:19]

If we're making this accessible, let's say a little more:

Returns the opener WebContentsImpl, if any.  This can be set to null if the
opener is closed or the page clears its window.opener.

[Fady Samuel, 2013/01/08 17:00:49]

Done.

+  WebContentsImpl* opener() const { return opener_; }
+
   // Creates a WebContents to be used as a browser plugin guest.
   static WebContentsImpl* CreateGuest(
       BrowserContext* browser_context,
       content::SiteInstance* site_instance,
+      int routing_id,
+      WebContentsImpl* base_web_contents,

[Charlie Reis, 2013/01/04 18:53:19]

Please call this opener_web_contents.

[Fady Samuel, 2013/01/08 17:00:49]

Done.

       int guest_instance_id,
       const BrowserPluginHostMsg_CreateGuest_Params& params);
 
   // Returns the content specific prefs for the given RVH.
   static webkit_glue::WebPreferences GetWebkitPrefs(
       RenderViewHost* rvh, const GURL& url);
 
   // Creates a swapped out RenderView. This is used by the browser plugin to
   // create a swapped out RenderView in the embedder render process for the
   // guest, to expose the guest's window object to the embedder.
@@ skipping 757 matching lines @@
   // Maps the ids of pending favicon downloads to their callbacks
   typedef std::map<int, FaviconDownloadCallback> FaviconDownloadMap;
   FaviconDownloadMap favicon_download_map_;
 
   DISALLOW_COPY_AND_ASSIGN(WebContentsImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_