sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart - Issue 11748016: Make ~/, round, ceil, floor, truncate return ints. Remove toInt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

Issue 11748016: Make ~/, round, ceil, floor, truncate return ints. Remove toInt. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart

Patch Set: Checked mode fixes. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« samples/third_party/dromaeo/tests/dom-modify-htmlidiomatic.dart ('K') | « samples/third_party/dromaeo/tests/dom-modify-htmlidiomatic.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/js_number.dart » ('j') | sdk/lib/_internal/compiler/implementation/lib/js_number.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart b/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

index b36c71cf2721393860254555d2f6017de279d763..917afcc4ae34f3839e53c2ad814f2ae64be30205 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart

@@ -200,7 +200,7 @@ class JavaScriptConstantSystem implements ConstantSystem {

double doubleValue = doubleResult.value;

if (!doubleValue.isInfinite && !doubleValue.isNaN &&

!constant.isMinusZero()) {

- int intValue = doubleValue.toInt();

+ int intValue = doubleValue.truncate();

if (intValue == doubleValue && integerFitsIntoDouble(intValue)) {

return new IntConstant(intValue);

}