samples/third_party/dromaeo/tests/dom-modify-htmlidiomatic.dart - Issue 11748016: Make ~/, round, ceil, floor, truncate return ints. Remove toInt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/third_party/dromaeo/tests/dom-modify-htmlidiomatic.dart

Issue 11748016: Make ~/, round, ceil, floor, truncate return ints. Remove toInt. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart

Patch Set: Checked mode fixes. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« samples/third_party/dromaeo/tests/dom-modify-html.dart ('K') | « samples/third_party/dromaeo/tests/dom-modify-html.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart » ('j') | sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: samples/third_party/dromaeo/tests/dom-modify-htmlidiomatic.dart

diff --git a/samples/third_party/dromaeo/tests/dom-modify-htmlidiomatic.dart b/samples/third_party/dromaeo/tests/dom-modify-htmlidiomatic.dart

index 9da20970d291609496fb9dd8bb916c74e105b4ca..17dc504a8ae7a01be10364427c4590497659961b 100644

--- a/samples/third_party/dromaeo/tests/dom-modify-htmlidiomatic.dart

+++ b/samples/third_party/dromaeo/tests/dom-modify-htmlidiomatic.dart

@@ -11,7 +11,7 @@ void main() {

String str = 'null';

// Very ugly way to build up the string, but let's mimic JS version as much as possible.

for (int i = 0; i < 1024; i++) {

- str = "$str${new String.fromCharCodes([((25 * Math.random()) + 97).toInt()])}";

+ str = "$str${new String.fromCharCodes([((25 * Math.random()) + 97).truncate()])}";

Lasse Reichstein Nielsen 2013/01/04 10:29:42 Line length.

}

List<Node> elems = <Node>[];