runtime/vm/intrinsifier_ia32.cc - Issue 11748016: Make ~/, round, ceil, floor, truncate return ints. Remove toInt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 11748016: Make ~/, round, ceil, floor, truncate return ints. Remove toInt. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart

Patch Set: Checked mode fixes. Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_ia32.cc

diff --git a/runtime/vm/intrinsifier_ia32.cc b/runtime/vm/intrinsifier_ia32.cc

index 1316abea7fe79bbdd47b92a80d0d71dce08626a3..3e58e46f67bfe21f083456bc118cca06e38531d5 100644

--- a/runtime/vm/intrinsifier_ia32.cc

+++ b/runtime/vm/intrinsifier_ia32.cc

@@ -1465,7 +1465,7 @@ bool Intrinsifier::Double_getIsNegative(Assembler* assembler) {

}

-bool Intrinsifier::Double_toInt(Assembler* assembler) {

+bool Intrinsifier::Double_truncate(Assembler* assembler) {

__ movl(EAX, Address(ESP, +1 * kWordSize));

__ movsd(XMM0, FieldAddress(EAX, Double::value_offset()));

__ cvttsd2si(EAX, XMM0);

« runtime/lib/double.cc ('K') | « runtime/vm/intrinsifier.h ('k') | runtime/vm/intrinsifier_x64.cc » ('j') | runtime/vm/snapshot_test.dart » ('J')