Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: runtime/vm/snapshot_test.dart

Issue 11748016: Make ~/, round, ceil, floor, truncate return ints. Remove toInt. (Closed) Base URL: https://dart.googlecode.com/svn/experimental/lib_v2/dart
Patch Set: Checked mode fixes. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/snapshot_test.dart
diff --git a/runtime/vm/snapshot_test.dart b/runtime/vm/snapshot_test.dart
index 97a933ba652b911be181322f60f3e5e0f6165a39..86d3d7b8288fcde5df8cdcd42c36163d6f850705 100644
--- a/runtime/vm/snapshot_test.dart
+++ b/runtime/vm/snapshot_test.dart
@@ -799,7 +799,7 @@ class ObjectString extends BenchmarkBase {
var result = "";
for (var i = 0; i < characters; i++) {
result += Strings.
- createFromCodePoints([(25 * Math.random()).toInt() + 97]);
+ createFromCodePoints([(25 * Math.random()).truncate() + 97]);
Lasse Reichstein Nielsen 2013/01/04 10:29:42 This is idiomatic code where "floor" would be more
}
result += result;
result += result;

Powered by Google App Engine
This is Rietveld 408576698