Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 11748012: Minor cleanup to how infobars handle expiry: (Closed)

Created:
7 years, 11 months ago by Peter Kasting
Modified:
7 years, 11 months ago
Reviewers:
Elliot Glaysher, sky
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, chromium-apps-reviews_chromium.org, Aaron Boodman, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Minor cleanup to how infobars handle expiry: * Make StoreActiveEntryUniqueID() take no args -- the arg was unnecessary. * Remove the unique ID setter and make its lone caller override ShouldExpireInternal() instead, to reduce the overall API surface area. * Prefer to override ShouldExpireInternal() instead of ShouldExpire() where possible, as that's a safer pattern if others copy-and-paste it, since it will change less behavior. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175362

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 4 (0 generated)
Peter Kasting
7 years, 11 months ago (2013-01-03 02:24:10 UTC) #1
Elliot Glaysher
lgtm
7 years, 11 months ago (2013-01-03 19:05:28 UTC) #2
Peter Kasting
sky: chrome/ OWNERS
7 years, 11 months ago (2013-01-03 19:16:47 UTC) #3
sky
7 years, 11 months ago (2013-01-07 17:19:54 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698