Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: chrome/browser/extensions/api/debugger/debugger_api.cc

Issue 11748012: Minor cleanup to how infobars handle expiry: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/debugger/debugger_api.cc
===================================================================
--- chrome/browser/extensions/api/debugger/debugger_api.cc (revision 174909)
+++ chrome/browser/extensions/api/debugger/debugger_api.cc (working copy)
@@ -71,10 +71,10 @@
private:
// ConfirmInfoBarDelegate:
- virtual bool ShouldExpire(
- const content::LoadCommittedDetails& details) const OVERRIDE;
virtual int GetButtons() const OVERRIDE;
virtual Type GetInfoBarType() const OVERRIDE;
+ virtual bool ShouldExpireInternal(
+ const content::LoadCommittedDetails& details) const OVERRIDE;
virtual string16 GetMessageText() const OVERRIDE;
virtual void InfoBarDismissed() OVERRIDE;
virtual bool Cancel() OVERRIDE;
@@ -363,11 +363,6 @@
client_host_ = NULL;
}
-bool ExtensionDevToolsInfoBarDelegate::ShouldExpire(
- const content::LoadCommittedDetails& details) const {
- return false;
-}
-
int ExtensionDevToolsInfoBarDelegate::GetButtons() const {
return BUTTON_CANCEL;
}
@@ -376,6 +371,11 @@
return WARNING_TYPE;
}
+bool ExtensionDevToolsInfoBarDelegate::ShouldExpireInternal(
+ const content::LoadCommittedDetails& details) const {
+ return false;
+}
+
string16 ExtensionDevToolsInfoBarDelegate::GetMessageText() const {
return l10n_util::GetStringFUTF16(IDS_DEV_TOOLS_INFOBAR_LABEL,
UTF8ToUTF16(client_name_));

Powered by Google App Engine
This is Rietveld 408576698