Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 11748003: Fixing up WebComponents types & tests (Closed)

Created:
7 years, 11 months ago by blois
Modified:
7 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Adding supported flags to web components types - Adding support annotations to web components types - Removed webkit prefix from Element.createShadowRoot BUG= Committed: https://code.google.com/p/dart/source/detail?r=16594

Patch Set 1 #

Patch Set 2 : #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -27 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 4 chunks +13 lines, -2 lines 2 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +10 lines, -1 line 0 comments Download
M tests/html/element_types_test.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M tests/html/html.status View 10 chunks +16 lines, -10 lines 3 comments Download
M tests/html/shadow_dom_layout_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/shadow_dom_test.dart View 2 chunks +27 lines, -9 lines 1 comment Download
M tests/html/shadowroot_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 3 chunks +12 lines, -0 lines 2 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
blois
7 years, 11 months ago (2013-01-02 18:46:30 UTC) #1
Emily Fortuna
https://codereview.chromium.org/11748003/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11748003/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart#newcode7925 sdk/lib/html/dart2js/html_dart2js.dart:7925: @SupportedBrowser(SupportedBrowser.CHROME, '25') @Experimental() no line break on this one, ...
7 years, 11 months ago (2013-01-02 18:54:04 UTC) #2
blois
https://codereview.chromium.org/11748003/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/11748003/diff/2001/sdk/lib/html/dart2js/html_dart2js.dart#newcode7925 sdk/lib/html/dart2js/html_dart2js.dart:7925: @SupportedBrowser(SupportedBrowser.CHROME, '25') @Experimental() On 2013/01/02 18:54:04, Emily Fortuna wrote: ...
7 years, 11 months ago (2013-01-02 21:28:41 UTC) #3
Emily Fortuna
7 years, 11 months ago (2013-01-02 21:49:34 UTC) #4
lgtm

https://codereview.chromium.org/11748003/diff/2001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/11748003/diff/2001/tests/html/html.status#new...
tests/html/html.status:194: shadow_dom_test/supported: Fail
On 2013/01/02 21:28:41, blois wrote:
> On 2013/01/02 18:54:04, Emily Fortuna wrote:
> > safari should be passing these tests, too right? It's also webkit and Safari
> 6?
> 
> It's only enabled with a flag in Chrome- so it's only passing in DRT, not
Chrome
> either.

gotcha.

Powered by Google App Engine
This is Rietveld 408576698