 Chromium Code Reviews
 Chromium Code Reviews Issue 11748003:
  Fixing up WebComponents types & tests  (Closed) 
  Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
    
  
    Issue 11748003:
  Fixing up WebComponents types & tests  (Closed) 
  Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart| Index: sdk/lib/html/dart2js/html_dart2js.dart | 
| diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart | 
| index 5da1bdfb5b877687ba9ba83831c2a3a3588f7590..9d475d6046cdc9479c18478d62b1a86f93066897 100644 | 
| --- a/sdk/lib/html/dart2js/html_dart2js.dart | 
| +++ b/sdk/lib/html/dart2js/html_dart2js.dart | 
| @@ -7921,7 +7921,9 @@ abstract class Element extends Node implements ElementTraversal native "*Element | 
| void $dom_setAttributeNS(String namespaceURI, String qualifiedName, String value) native; | 
| /// @domName Element.webkitCreateShadowRoot; @docsEditable true | 
| - ShadowRoot webkitCreateShadowRoot() native; | 
| + @JSName('webkitCreateShadowRoot') | 
| + @SupportedBrowser(SupportedBrowser.CHROME, '25') @Experimental() | 
| 
Emily Fortuna
2013/01/02 18:54:04
no line break on this one, but the others are fine
 
blois
2013/01/02 21:28:41
Similar issue that came up in an earlier CL- it's
 | 
| + ShadowRoot createShadowRoot() native; | 
| /// @domName Element.webkitMatchesSelector; @docsEditable true | 
| @JSName('webkitMatchesSelector') | 
| @@ -15925,8 +15927,15 @@ class SelectElement extends Element native "*HTMLSelectElement" { | 
| /// @domName HTMLShadowElement; @docsEditable true | 
| +@SupportedBrowser(SupportedBrowser.CHROME, '25') | 
| +@Experimental() | 
| class ShadowElement extends Element native "*HTMLShadowElement" { | 
| + /** | 
| + * Checks if this type is supported on the current platform | 
| + */ | 
| + static bool get supported => Element.isTagSupported('shadow'); | 
| + | 
| /// @domName HTMLShadowElement.olderShadowRoot; @docsEditable true | 
| final ShadowRoot olderShadowRoot; | 
| @@ -15941,6 +15950,8 @@ class ShadowElement extends Element native "*HTMLShadowElement" { | 
| /// @domName ShadowRoot | 
| +@SupportedBrowser(SupportedBrowser.CHROME, '25') | 
| +@Experimental() | 
| class ShadowRoot extends DocumentFragment native "*ShadowRoot" { | 
| /// @domName ShadowRoot.activeElement; @docsEditable true | 
| @@ -15978,7 +15989,7 @@ class ShadowRoot extends DocumentFragment native "*ShadowRoot" { | 
| DomSelection getSelection() native; | 
| static bool get supported => | 
| - JS('bool', '!!(window.ShadowRoot || window.WebKitShadowRoot || Element.prototype.webkitCreateShadowRoot)'); | 
| + JS('bool', '!!(Element.prototype.webkitCreateShadowRoot)'); | 
| } | 
| // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 
| // for details. All rights reserved. Use of this source code is governed by a |