Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1174713002: Reland of 'Optimize trivial regexp disjunctions' CL 1176453002 (Closed)

Created:
5 years, 6 months ago by Erik Corry Chromium.org
Modified:
5 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of 'Optimize trivial regexp disjunctions' CL 1176453002 Original code review: https://codereview.chromium.org/1176453002/ TBR=yangguo@chromium.org BUG=chromium:482998 LOG=n Committed: https://crrev.com/85fab0fa092e8d979413f6a61baec3abe26e568d Cr-Commit-Position: refs/heads/master@{#28884}

Patch Set 1 #

Patch Set 2 : Fix for the out-of-bounds sort that caused the revert #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -7 lines) Patch
M src/ast.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/jsregexp.h View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.cc View 1 1 chunk +190 lines, -0 lines 1 comment Download
M src/list.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/list-inl.h View 2 chunks +31 lines, -4 lines 0 comments Download
M src/vector.h View 2 chunks +14 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Erik Corry Chromium.org
5 years, 6 months ago (2015-06-09 20:25:00 UTC) #1
Erik Corry Chromium.org
https://codereview.chromium.org/1174713002/diff/20001/src/jsregexp.cc File src/jsregexp.cc (right): https://codereview.chromium.org/1174713002/diff/20001/src/jsregexp.cc#newcode4845 src/jsregexp.cc:4845: if (i == length) break; This is the fix.
5 years, 6 months ago (2015-06-09 20:27:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1174713002/20001
5 years, 6 months ago (2015-06-09 20:27:17 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 21:57:18 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/85fab0fa092e8d979413f6a61baec3abe26e568d Cr-Commit-Position: refs/heads/master@{#28884}
5 years, 6 months ago (2015-06-09 21:57:35 UTC) #6
erikcorry
5 years, 6 months ago (2015-06-09 23:06:10 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1172893002/ by erikcorry@google.com.

The reason for reverting is: Tree looks like a Christmas tree and this isn't
helping.

Powered by Google App Engine
This is Rietveld 408576698