src/ast.h - Issue 1174713002: Reland of 'Optimize trivial regexp disjunctions' CL 1176453002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast.h

Issue 1174713002: Reland of 'Optimize trivial regexp disjunctions' CL 1176453002 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix for the out-of-bounds sort that caused the revert Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ast.h

diff --git a/src/ast.h b/src/ast.h

index 01154d37628a9f8518497f8428c8523922db54be..0dc9e6066630898e326880092c60b157e4e8e6a7 100644

--- a/src/ast.h

+++ b/src/ast.h

@@ -2872,6 +2872,9 @@ class RegExpDisjunction final : public RegExpTree {

int max_match() override { return max_match_; }

ZoneList<RegExpTree*>* alternatives() { return alternatives_; }

private:

+ bool SortConsecutiveAtoms(RegExpCompiler* compiler);

+ void RationalizeConsecutiveAtoms(RegExpCompiler* compiler);

+ void FixSingleCharacterDisjunctions(RegExpCompiler* compiler);

ZoneList<RegExpTree*>* alternatives_;

int min_match_;

int max_match_;

« no previous file with comments | « no previous file | src/jsregexp.h » ('j') | src/jsregexp.cc » ('J')