Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 11747006: Merge 138393 (Closed)

Created:
7 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 138393 > Expose ArrayBufferView constructor on DOMWindow > https://bugs.webkit.org/show_bug.cgi?id=105605 > > Reviewed by Sam Weinig. > > Source/WebCore: > > Update IDL to track recent spec change exposing ArrayBufferView > constructor on DOMWindow for instanceof checks. There are no > constructors exposed in the Web IDL, however, so calling it via > operator new throws TypeError. > > Test (updated): fast/canvas/webgl/array-unit-tests.html > > * html/canvas/ArrayBufferView.idl: > Removed OmitConstructor attribute. > * page/DOMWindow.idl: > Exposed ArrayBufferView constructor function attribute. > > LayoutTests: > > Updated test from Khronos repository. > > * fast/canvas/webgl/array-unit-tests-expected.txt: > * fast/canvas/webgl/array-unit-tests.html: > TBR=kbr@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -5 lines) Patch
M LayoutTests/fast/canvas/webgl/array-unit-tests.html View 6 chunks +50 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/WebCore/html/canvas/ArrayBufferView.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/WebCore/page/DOMWindow.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ken Russell (switch to Gerrit)
7 years, 11 months ago (2013-01-02 23:53:48 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698