|
|
Cleanup history favicon code
This removes the currently unused IconURLSizesMap.
It also uses the 'expired' parameter in the 'favicon_bitmaps' table instead of the 'sizes' attribute in the 'favicons' table.
Given that we are unlikely going to move to storing unresized bitmaps to the database due to perf problems when resizing the favicon each time it is requested, using the IconURLSizesMap is probably not the right solution in the future anyways. This CL should make the code in HistoryBackend less scary.
BUG=None
Test=No functionality change
HistoryBackendTest.*
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178432
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+310 lines, -759 lines) |
Patch |
 |
M |
chrome/browser/extensions/extension_web_ui.cc
|
View
|
1
2
3
|
2 chunks |
+1 line, -14 lines |
0 comments
|
Download
|
|
M |
chrome/browser/favicon/favicon_handler.h
|
View
|
1
2
3
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
|
M |
chrome/browser/favicon/favicon_handler.cc
|
View
|
1
2
3
|
4 chunks |
+30 lines, -50 lines |
0 comments
|
Download
|
|
M |
chrome/browser/favicon/favicon_handler_unittest.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -12 lines |
0 comments
|
Download
|
|
M |
chrome/browser/favicon/favicon_service.h
|
View
|
|
3 chunks |
+4 lines, -21 lines |
0 comments
|
Download
|
|
M |
chrome/browser/favicon/favicon_service.cc
|
View
|
|
7 chunks |
+8 lines, -26 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/android/android_provider_backend_unittest.cc
|
View
|
1
2
3
|
3 chunks |
+3 lines, -27 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history.h
|
View
|
1
2
3
|
1 chunk |
+8 lines, -15 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history.cc
|
View
|
1
2
3
|
6 chunks |
+12 lines, -13 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history_backend.h
|
View
|
1
2
3
|
8 chunks |
+15 lines, -54 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history_backend.cc
|
View
|
1
2
3
|
16 chunks |
+85 lines, -142 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history_backend_unittest.cc
|
View
|
1
2
3
|
33 chunks |
+137 lines, -360 lines |
0 comments
|
Download
|
|
M |
chrome/browser/history/history_types.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
|
View
|
1
2
3
|
3 chunks |
+4 lines, -18 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|
Chromium Code Reviews
Issue
11746010:
Cleanup history favicon code (Closed)
