Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1951)

Unified Diff: chrome/browser/favicon/favicon_handler_unittest.cc

Issue 11746010: Cleanup history favicon code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_handler.cc ('k') | chrome/browser/favicon/favicon_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_handler_unittest.cc
diff --git a/chrome/browser/favicon/favicon_handler_unittest.cc b/chrome/browser/favicon/favicon_handler_unittest.cc
index 3f824a7ce8d8b6903c5c5f44fa75ca989d3a64ef..445c1685e698ec12c11331e257a256b52a7d37c8 100644
--- a/chrome/browser/favicon/favicon_handler_unittest.cc
+++ b/chrome/browser/favicon/favicon_handler_unittest.cc
@@ -314,18 +314,7 @@ namespace {
void HistoryRequestHandler::InvokeCallback() {
if (!callback_.is_null()) {
- history::IconURLSizesMap icon_url_sizes;
- // Build IconURLSizesMap such that the requirement that all the icon URLs
- // in |history_results_| be present in |icon_url_sizes| holds.
- // Add the pixel size for each of |history_results_| to |icon_url_sizes|
- // as empty favicon sizes has a special meaning.
- for (size_t i = 0; i < history_results_.size(); ++i) {
- const history::FaviconBitmapResult& bitmap_result = history_results_[i];
- const GURL& icon_url = bitmap_result.icon_url;
- icon_url_sizes[icon_url].push_back(bitmap_result.pixel_size);
- }
-
- callback_.Run(history_results_, icon_url_sizes);
+ callback_.Run(history_results_);
}
}
« no previous file with comments | « chrome/browser/favicon/favicon_handler.cc ('k') | chrome/browser/favicon/favicon_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698