Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: media/base/android/java/src/org/chromium/media/MediaCodecBridge.java

Issue 1174523002: Use Chromium's Logging instead of Android's Logging for media files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: hardcoding cr. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
diff --git a/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java b/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
index 04066e0e22f5a089e93afae135d531cdb0dcb666..eb62b9b9692e0f65e894c3fb49fc90bf45ed1a92 100644
--- a/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
+++ b/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
@@ -32,7 +32,7 @@ import java.util.Map;
*/
@JNINamespace("media")
class MediaCodecBridge {
- private static final String TAG = "MediaCodecBridge";
+ private static final String TAG = "cr.media";
// Error code for MediaCodecBridge. Keep this value in sync with
// MediaCodecStatus in media_codec_bridge.h.
@@ -229,8 +229,8 @@ class MediaCodecBridge {
codecName = mediaCodec.getName();
mediaCodec.release();
} catch (Exception e) {
- Log.w(TAG, "getDefaultCodecName: Failed to create MediaCodec: "
- + mime + ", direction: " + direction, e);
+ Log.w(TAG, "getDefaultCodecName: Failed to create MediaCodec: %s, direction: %d",
+ mime, direction, e);
}
}
return codecName;
@@ -342,8 +342,8 @@ class MediaCodecBridge {
}
}
} catch (Exception e) {
- Log.e(TAG, "Failed to create MediaCodec: " + mime + ", isSecure: "
- + isSecure + ", direction: " + direction, e);
+ Log.e(TAG, "Failed to create MediaCodec: %s, isSecure: %s, direction: %d",
+ mime, isSecure, direction, e);
}
if (mediaCodec == null) {

Powered by Google App Engine
This is Rietveld 408576698