Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java

Issue 1174523002: Use Chromium's Logging instead of Android's Logging for media files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: hardcoding cr. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java
diff --git a/media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java b/media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java
index 21def1fd9fd75b1d6bd058404a3e9ca5acab4dd9..ba470fd526dbce3f378ec8417394aded436e5b83 100644
--- a/media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java
+++ b/media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java
@@ -6,7 +6,8 @@ package org.chromium.media;
import android.content.Context;
import android.graphics.ImageFormat;
-import android.util.Log;
+
+import org.chromium.base.Log;
import java.util.ArrayList;
import java.util.List;
@@ -41,7 +42,7 @@ public class VideoCaptureAndroid extends VideoCaptureCamera {
private int mExpectedFrameSize;
private static final int NUM_CAPTURE_BUFFERS = 3;
- private static final String TAG = "VideoCaptureAndroid";
+ private static final String TAG = "cr.media";
static int getNumberOfCameras() {
return android.hardware.Camera.getNumberOfCameras();
@@ -67,7 +68,7 @@ public class VideoCaptureAndroid extends VideoCaptureCamera {
try {
camera = android.hardware.Camera.open(id);
} catch (RuntimeException ex) {
- Log.e(TAG, "Camera.open: " + ex);
+ Log.e(TAG, "Camera.open: ", ex);
jdduke (slow) 2015/06/25 16:34:03 Are we missing a %s here?
dgn 2015/06/25 16:46:09 Depends on what we want to do. Currently it should
jdduke (slow) 2015/06/25 16:53:12 Oh nevermind, I guess format just appends the stri
dgn 2015/06/25 17:02:56 Well, Throwables have a special handling when they
return null;
}
android.hardware.Camera.Parameters parameters = getCameraParameters(camera);

Powered by Google App Engine
This is Rietveld 408576698