Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java

Issue 1174523002: Use Chromium's Logging instead of Android's Logging for media files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: hardcoding cr. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
diff --git a/media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java b/media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
index c520e34e172f011b90717b0d399a24f2aea6eccc..e71ca86fe181375acbe11f2c75d4a562c0c25055 100644
--- a/media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
+++ b/media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java
@@ -24,10 +24,10 @@ import android.os.Handler;
import android.os.HandlerThread;
import android.os.Process;
import android.provider.Settings;
-import android.util.Log;
import org.chromium.base.CalledByNative;
import org.chromium.base.JNINamespace;
+import org.chromium.base.Log;
import java.util.ArrayList;
import java.util.Arrays;
@@ -35,7 +35,7 @@ import java.util.List;
@JNINamespace("media")
class AudioManagerAndroid {
- private static final String TAG = "AudioManagerAndroid";
+ private static final String TAG = "cr.media";
// Set to true to enable debug logs. Avoid in production builds.
// NOTE: always check in as false.
@@ -373,8 +373,8 @@ class AudioManagerAndroid {
if (DEBUG) logd("setDevice: " + deviceId);
if (!mIsInitialized) return false;
if (!mHasModifyAudioSettingsPermission || !mHasRecordAudioPermission) {
- Log.w(TAG, "Requires MODIFY_AUDIO_SETTINGS and RECORD_AUDIO");
- Log.w(TAG, "Selected device will not be available for recording");
+ Log.w(TAG, "Requires MODIFY_AUDIO_SETTINGS and RECORD_AUDIO. "
+ + "Selected device will not be available for recording");
return false;
}
@@ -416,8 +416,8 @@ class AudioManagerAndroid {
if (DEBUG) logd("getAudioInputDeviceNames");
if (!mIsInitialized) return null;
if (!mHasModifyAudioSettingsPermission || !mHasRecordAudioPermission) {
- Log.w(TAG, "Requires MODIFY_AUDIO_SETTINGS and RECORD_AUDIO");
- Log.w(TAG, "No audio device will be available for recording");
+ Log.w(TAG, "Requires MODIFY_AUDIO_SETTINGS and RECORD_AUDIO. "
+ + "No audio device will be available for recording");
return null;
}

Powered by Google App Engine
This is Rietveld 408576698