Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: extensions/renderer/file_system_natives.cc

Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/blob_native_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/file_system_natives.cc
diff --git a/extensions/renderer/file_system_natives.cc b/extensions/renderer/file_system_natives.cc
index a06eec8cdd35de2a7cc30b80f18a75e2c3f93b3a..67b5d13f2a808c6a720403d28ff3c1c383cf79a6 100644
--- a/extensions/renderer/file_system_natives.cc
+++ b/extensions/renderer/file_system_natives.cc
@@ -65,7 +65,7 @@ void FileSystemNatives::GetIsolatedFileSystem(
blink::WebFileSystemTypeIsolated,
blink::WebString::fromUTF8(name),
root_url)
- .toV8Value(args.Holder(), args.GetIsolate()));
+ .toV8Value(context()->v8_context()->Global(), args.GetIsolate()));
}
void FileSystemNatives::GetFileEntry(
@@ -105,7 +105,7 @@ void FileSystemNatives::GetFileEntry(
file_system_root_url)
.createV8Entry(blink::WebString::fromUTF8(file_path_string),
entry_type,
- args.Holder(),
+ context()->v8_context()->Global(),
args.GetIsolate()));
}
@@ -150,7 +150,8 @@ void FileSystemNatives::GetDOMError(
blink::WebDOMError dom_error = blink::WebDOMError::create(
blink::WebString::fromUTF8(name), blink::WebString::fromUTF8(message));
args.GetReturnValue().Set(
- dom_error.toV8Value(args.Holder(), args.GetIsolate()));
+ dom_error.toV8Value(context()->v8_context()->Global(),
+ args.GetIsolate()));
}
} // namespace extensions
« no previous file with comments | « extensions/renderer/blob_native_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698