chrome/renderer/extensions/file_manager_private_custom_bindings.cc - Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/extensions/file_manager_private_custom_bindings.cc

Issue 1174343003: blink:bindings: Passes the global context instead of |this| in JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/renderer/extensions/file_manager_private_custom_bindings.h"	5 #include "chrome/renderer/extensions/file_manager_private_custom_bindings.h"

6	6

7 #include <string>	7 #include <string>

8	8

9 #include "base/basictypes.h"	9 #include "base/basictypes.h"

10 #include "base/logging.h"	10 #include "base/logging.h"

(...skipping 22 matching lines...) Expand all Loading...
33 std::string root_url(*v8::String::Utf8Value(args[1]));	33 std::string root_url(*v8::String::Utf8Value(args[1]));

34	34

35 blink::WebLocalFrame* webframe =	35 blink::WebLocalFrame* webframe =

36 blink::WebLocalFrame::frameForContext(context()->v8_context());	36 blink::WebLocalFrame::frameForContext(context()->v8_context());

37 DCHECK(webframe);	37 DCHECK(webframe);

38 args.GetReturnValue().Set(	38 args.GetReturnValue().Set(

39 blink::WebDOMFileSystem::create(webframe,	39 blink::WebDOMFileSystem::create(webframe,

40 blink::WebFileSystemTypeExternal,	40 blink::WebFileSystemTypeExternal,

41 blink::WebString::fromUTF8(name),	41 blink::WebString::fromUTF8(name),

42 GURL(root_url))	42 GURL(root_url))

43 .toV8Value(args.Holder(), args.GetIsolate()));	43 .toV8Value(context()->v8_context()->Global(), args.GetIsolate()));

44 }	44 }

45	45

46 } // namespace extensions	46 } // namespace extensions

OLD	NEW

« no previous file with comments | « no previous file | chrome/renderer/extensions/media_galleries_custom_bindings.h » ('j') | no next file with comments »