Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1174313002: Allow setting break-on-exceptions option over the service protocol. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 4c42991a45aa3a7d78642d0c6d252d7808af35a2..709033bca4db91c4f6b6f358200f3b2bd67eac75 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -1265,6 +1265,14 @@ class Isolate extends ServiceObjectOwner with Coverage {
return invokeRpc('setName', {'name': newName});
}
+ Future getExceptionPauseInfo() {
+ return invokeRpc('_getExceptionPauseInfo', {});
+ }
+
+ Future setExceptionPauseInfo(String exceptions) {
+ return invokeRpc('_setExceptionPauseInfo', {'exceptions': exceptions});
+ }
+
Future<ServiceMap> getStack() {
return invokeRpc('getStack', {});
}
@@ -1481,7 +1489,7 @@ class ServiceEvent extends ServiceObject {
@observable String kind;
@observable Breakpoint breakpoint;
@observable Frame topFrame;
- @observable ServiceMap exception;
+ @observable Instance exception;
@observable ServiceObject inspectee;
@observable ByteData data;
@observable int count;
@@ -2344,7 +2352,8 @@ class Script extends ServiceObject with Coverage {
@observable int lineOffset;
@observable int columnOffset;
@observable Library library;
- bool get canCache => true;
+
+ bool get canCache => !_id.startsWith(ServiceMap.objectIdRingPrefix);
rmacnak 2015/06/11 17:31:17 This still doesn't pass the assert on 309.
Cutch 2015/06/11 21:20:12 example of the assert on 309 failing?
rmacnak 2015/06/12 00:09:38 Nvm, I needed to do this for function as well (eva
bool get immutable => true;
String _shortUri;
@@ -3254,6 +3263,8 @@ class Frame extends ServiceObject {
this.code = map['code'];
this.variables = map['vars'];
}
+
+ String toString() => "Frame(${function.qualifiedName})";
}

Powered by Google App Engine
This is Rietveld 408576698