Allow setting break-on-exceptions option over the service protocol.

runtime/observatory/lib/src/service/object.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of service;
 
 /// An RpcException represents an exceptional event that happened
 /// while invoking an rpc.
 abstract class RpcException implements Exception {
   RpcException(this.message);
@@ skipping 1247 matching lines @@
   }
 
   Future stepOut() {
     return invokeRpc('resume', {'step': 'Out'});
   }
 
   Future setName(String newName) {
     return invokeRpc('setName', {'name': newName});
   }
 
+  Future getExceptionPauseInfo() {
+    return invokeRpc('_getExceptionPauseInfo', {});
+  }
+
+  Future setExceptionPauseInfo(String exceptions) {
+    return invokeRpc('_setExceptionPauseInfo', {'exceptions': exceptions});
+  }
+
   Future<ServiceMap> getStack() {
     return invokeRpc('getStack', {});
   }
 
   Future<ServiceObject> _eval(ServiceObject target,
                               String expression) {
     Map params = {
       'targetId': target.id,
       'expression': expression,
     };
@@ skipping 196 matching lines @@
 
   ServiceEvent._empty(ServiceObjectOwner owner) : super._empty(owner);
 
   ServiceEvent.connectionClosed(this.reason) : super._empty(null) {
     kind = kConnectionClosed;
   }
 
   @observable String kind;
   @observable Breakpoint breakpoint;
   @observable Frame topFrame;
-  @observable ServiceMap exception;
+  @observable Instance exception;
   @observable ServiceObject inspectee;
   @observable ByteData data;
   @observable int count;
   @observable String reason;
   int chunkIndex, chunkCount, nodeCount;
 
   @observable bool get isPauseEvent {
     return (kind == kPauseStart ||
             kind == kPauseExit ||
             kind == kPauseBreakpoint ||
@@ skipping 842 matching lines @@
   Set<CallSite> callSites = new Set<CallSite>();
   final lines = new ObservableList<ScriptLine>();
   final _hits = new Map<int, int>();
   @observable String uri;
   @observable String kind;
   @observable int firstTokenPos;
   @observable int lastTokenPos;
   @observable int lineOffset;
   @observable int columnOffset;
   @observable Library library;
-  bool get canCache => true;
+
+  bool get canCache => !_id.startsWith(ServiceMap.objectIdRingPrefix);

[rmacnak, 2015/06/11 17:31:17]

This still doesn't pass the assert on 309.

[Cutch, 2015/06/11 21:20:12]

example of the assert on 309 failing?

[rmacnak, 2015/06/12 00:09:38]

Nvm, I needed to do this for function as well (eval function).

   bool get immutable => true;
 
   String _shortUri;
 
   Script._empty(ServiceObjectOwner owner) : super._empty(owner);
 
   ScriptLine getLine(int line) {
     assert(_loaded);
     assert(line >= 1);
     return lines[line - lineOffset - 1];
@@ skipping 889 matching lines @@
   void _update(ObservableMap map, bool mapIsRef) {
     assert(!mapIsRef);
     _loaded = true;
     _upgradeCollection(map, owner);
     this.index = map['index'];
     this.function = map['function'];
     this.location = map['location'];
     this.code = map['code'];
     this.variables = map['vars'];
   }
+
+  String toString() => "Frame(${function.qualifiedName})";
 }
 
 
 class ServiceMessage extends ServiceObject {
   @observable int index;
   @observable String messageObjectId;
   @observable int size;
   @observable ServiceFunction handler;
   @observable SourceLocation location;
 
@@ skipping 52 matching lines @@
     var v = list[i];
     if ((v is ObservableMap) && _isServiceMap(v)) {
       list[i] = owner.getFromMap(v);
     } else if (v is ObservableList) {
       _upgradeObservableList(v, owner);
     } else if (v is ObservableMap) {
       _upgradeObservableMap(v, owner);
     }
   }
 }