Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2662)

Unified Diff: Source/web/tests/MHTMLTest.cpp

Issue 1174283002: Fix unit test style in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove static Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/ListenerLeakTest.cpp ('k') | Source/web/tests/OpenTypeVerticalDataTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/MHTMLTest.cpp
diff --git a/Source/web/tests/MHTMLTest.cpp b/Source/web/tests/MHTMLTest.cpp
index 8dcef2c35b24cdfd23d6e75cad2db448292a9345..4fbd4380e7f807ccfcb77d5fcbc0374878e6bf4c 100644
--- a/Source/web/tests/MHTMLTest.cpp
+++ b/Source/web/tests/MHTMLTest.cpp
@@ -51,11 +51,9 @@
#include "web/tests/FrameTestHelpers.h"
#include <gtest/gtest.h>
-using namespace blink;
-
using blink::URLTestHelpers::toKURL;
-namespace {
+namespace blink {
class LineReader {
public:
@@ -83,9 +81,6 @@ private:
size_t m_index;
};
-using blink::URLTestHelpers::toKURL;
-using namespace blink;
-
class MHTMLTest : public testing::Test {
public:
MHTMLTest()
@@ -95,12 +90,12 @@ public:
}
protected:
- virtual void SetUp()
+ void SetUp() override
{
m_helper.initialize();
}
- virtual void TearDown()
+ void TearDown() override
{
Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
}
@@ -150,8 +145,6 @@ protected:
return MHTMLArchive::generateMHTMLData(m_resources, encodingPolicy, title, mime);
}
-
-
private:
PassRefPtr<SharedBuffer> readFile(const char* fileName)
{
@@ -220,4 +213,5 @@ TEST_F(MHTMLTest, TestMHTMLEncoding)
}
EXPECT_EQ(12, sectionCheckedCount);
}
-}
+
+} // namespace blink
« no previous file with comments | « Source/web/tests/ListenerLeakTest.cpp ('k') | Source/web/tests/OpenTypeVerticalDataTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698