Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1806)

Unified Diff: Source/web/tests/ListenerLeakTest.cpp

Issue 1174283002: Fix unit test style in Source/web/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove static Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/tests/LinkHighlightTest.cpp ('k') | Source/web/tests/MHTMLTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/ListenerLeakTest.cpp
diff --git a/Source/web/tests/ListenerLeakTest.cpp b/Source/web/tests/ListenerLeakTest.cpp
index 975767404e5ad2ca7746a084aaac773f7f7ba805..d4b3003498393396e27576c6fc0e202235333937 100644
--- a/Source/web/tests/ListenerLeakTest.cpp
+++ b/Source/web/tests/ListenerLeakTest.cpp
@@ -39,9 +39,7 @@
#include <v8/include/v8-profiler.h>
#include <v8/include/v8.h>
-using namespace blink;
-
-namespace {
+namespace blink {
const v8::HeapGraphNode* GetProperty(const v8::HeapGraphNode* node, v8::HeapGraphEdge::Type type, const char* name)
{
@@ -53,7 +51,7 @@ const v8::HeapGraphNode* GetProperty(const v8::HeapGraphNode* node, v8::HeapGrap
return prop->GetToNode();
}
}
- return 0;
+ return nullptr;
}
int GetNumObjects(const char* constructor)
@@ -96,7 +94,7 @@ public:
webViewHelper.initializeAndLoad(baseURL + fileName, executeScript);
}
- virtual void TearDown() override
+ void TearDown() override
{
Platform::current()->unitTestSupport()->unregisterAllMockedURLs();
}
@@ -122,4 +120,4 @@ TEST_F(ListenerLeakTest, HiddenReferences)
ASSERT_EQ(1, GetNumObjects("EventListenerLeakTestObject2"));
}
-} // namespace
+} // namespace blink
« no previous file with comments | « Source/web/tests/LinkHighlightTest.cpp ('k') | Source/web/tests/MHTMLTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698