Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1174253003: Make the stocks popup menu fade in (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make the stocks popup menu fade in The final animation is more involved, but this CL starts implementing the menu animation by making it fade in. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/3b408194629927c0386e08159bfc28158650f4e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -45 lines) Patch
M sky/engine/core/painting/Rect.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
D sky/engine/platform/graphics/GraphicsContext.cpp.rej View 1 chunk +0 lines, -22 lines 0 comments Download
D sky/engine/platform/graphics/GraphicsContext.h.rej View 1 chunk +0 lines, -15 lines 0 comments Download
M sky/sdk/lib/framework/components2/popup_menu.dart View 1 chunk +11 lines, -8 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-10 23:55:07 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-06-10 23:59:12 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-11 00:28:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b408194629927c0386e08159bfc28158650f4e5.

Powered by Google App Engine
This is Rietveld 408576698