Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Side by Side Diff: sky/engine/core/painting/Rect.cpp

Issue 1174253003: Make the stocks popup menu fade in (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/engine/platform/graphics/GraphicsContext.cpp.rej » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sky/engine/config.h" 5 #include "sky/engine/config.h"
6 #include "sky/engine/core/painting/Rect.h" 6 #include "sky/engine/core/painting/Rect.h"
7 7
8 #include "sky/engine/core/script/dom_dart_state.h" 8 #include "sky/engine/core/script/dom_dart_state.h"
9 #include "sky/engine/tonic/dart_error.h" 9 #include "sky/engine/tonic/dart_error.h"
10 #include "sky/engine/tonic/dart_value.h" 10 #include "sky/engine/tonic/dart_value.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 // Convert dart_rect._value[0...3] ==> SkRect. 15 // Convert dart_rect._value[0...3] ==> SkRect.
16 Rect DartConverter<Rect>::FromArgumentsWithNullCheck(Dart_NativeArguments args, 16 Rect DartConverter<Rect>::FromArgumentsWithNullCheck(Dart_NativeArguments args,
17 int index, 17 int index,
18 Dart_Handle& exception) { 18 Dart_Handle& exception) {
19 Rect result; 19 Rect result;
20 result.is_null = true; 20 result.is_null = true;
21 21
22 Dart_Handle dart_rect = Dart_GetNativeArgument(args, index); 22 Dart_Handle dart_rect = Dart_GetNativeArgument(args, index);
23 DCHECK(!LogIfError(dart_rect)); 23 DCHECK(!LogIfError(dart_rect));
24 24
25 if (Dart_IsNull(dart_rect))
26 return result;
27
25 Dart_Handle value = 28 Dart_Handle value =
26 Dart_GetField(dart_rect, DOMDartState::Current()->value_handle()); 29 Dart_GetField(dart_rect, DOMDartState::Current()->value_handle());
27 if (Dart_IsNull(value)) 30 if (Dart_IsNull(value))
28 return result; 31 return result;
29 32
30 Dart_TypedData_Type type; 33 Dart_TypedData_Type type;
31 float* data = nullptr; 34 float* data = nullptr;
32 intptr_t num_elements = 0; 35 intptr_t num_elements = 0;
33 Dart_TypedDataAcquireData( 36 Dart_TypedDataAcquireData(
34 value, &type, reinterpret_cast<void**>(&data), &num_elements); 37 value, &type, reinterpret_cast<void**>(&data), &num_elements);
35 DCHECK(!LogIfError(value)); 38 DCHECK(!LogIfError(value));
36 ASSERT(type == Dart_TypedData_kFloat32 && num_elements == 4); 39 ASSERT(type == Dart_TypedData_kFloat32 && num_elements == 4);
37 40
38 SkScalar* dest[] = { 41 SkScalar* dest[] = {
39 &result.sk_rect.fLeft, 42 &result.sk_rect.fLeft,
40 &result.sk_rect.fTop, 43 &result.sk_rect.fTop,
41 &result.sk_rect.fRight, 44 &result.sk_rect.fRight,
42 &result.sk_rect.fBottom 45 &result.sk_rect.fBottom
43 }; 46 };
44 for (intptr_t i = 0; i < 4; ++i) 47 for (intptr_t i = 0; i < 4; ++i)
45 *dest[i] = data[i]; 48 *dest[i] = data[i];
46 49
47 Dart_TypedDataReleaseData(value); 50 Dart_TypedDataReleaseData(value);
48 51
49 result.is_null = false; 52 result.is_null = false;
50 return result; 53 return result;
51 } 54 }
52 55
53 } // namespace blink 56 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | sky/engine/platform/graphics/GraphicsContext.cpp.rej » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698