Issue 11742033: requestAutocomplete: only menu-suggest "complete" profiles.

Issue 11742033: requestAutocomplete: only menu-suggest "complete" profiles. (Closed)

Created:
7 years, 11 months ago by Evan Stade

Modified:
7 years, 11 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

requestAutocomplete: only menu-suggest "complete" profiles. BUG=157270 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175085

Patch Set 1 #

Total comments: 4

Patch Set 2 : review feedback #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
	M	chrome/browser/ui/autofill/autofill_dialog_controller.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/autofill/autofill_dialog_controller.cc	View	1	3 chunks	+19 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

this is a lightweight version of "verified" profiles. Even when we do get around to ...

7 years, 11 months ago (2013-01-03 23:32:29 UTC) #1

Ilya Sherman

LGTM https://codereview.chromium.org/11742033/diff/1/chrome/browser/autofill/personal_data_manager.cc File chrome/browser/autofill/personal_data_manager.cc (left): https://codereview.chromium.org/11742033/diff/1/chrome/browser/autofill/personal_data_manager.cc#oldcode933 chrome/browser/autofill/personal_data_manager.cc:933: nit: This diff seems unrelated to this CL; ...

7 years, 11 months ago (2013-01-03 23:54:03 UTC) #2

Evan Stade

7 years, 11 months ago (2013-01-04 02:16:58 UTC) #3

https://codereview.chromium.org/11742033/diff/1/chrome/browser/autofill/perso...
File chrome/browser/autofill/personal_data_manager.cc (left):

https://codereview.chromium.org/11742033/diff/1/chrome/browser/autofill/perso...
chrome/browser/autofill/personal_data_manager.cc:933: 
On 2013/01/03 23:54:04, Ilya Sherman wrote:
> nit: This diff seems unrelated to this CL; please split it out into a separate
> one.

that would be the saddest CL ever. Since you don't like it as part of this CL,
I'll just drop it.

https://codereview.chromium.org/11742033/diff/1/chrome/browser/ui/autofill/au...
File chrome/browser/ui/autofill/autofill_dialog_controller.h (right):

https://codereview.chromium.org/11742033/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller.h:157: bool
IsCompleteProfile(const AutofillProfile* profile);
On 2013/01/03 23:54:04, Ilya Sherman wrote:
> nit: Pass by const reference

Done.

Expand Messages | Collapse Messages