requestAutocomplete: only menu-suggest "complete" profiles.

chrome/browser/ui/autofill/autofill_dialog_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller.h"
 
 #include "base/logging.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 174 matching lines @@
   FilterInputs(form_structure_,
                kBillingInputs,
                arraysize(kBillingInputs),
                &requested_billing_fields_);
 
   FilterInputs(form_structure_,
                kShippingInputs,
                arraysize(kShippingInputs),
                &requested_shipping_fields_);
 
-  // TODO(estade): make this actually check if it's a first run.
-  bool first_run = true;
-  if (!first_run)
-    GenerateComboboxModels();
+  GenerateComboboxModels();
 
   // TODO(estade): don't show the dialog if the site didn't specify the right
   // fields. First we must figure out what the "right" fields are.
   view_.reset(AutofillDialogView::Create(this));
   view_->Show();
 }
 
 string16 AutofillDialogController::DialogTitle() const {
   return l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_TITLE);
 }
@@ skipping 226 matching lines @@
   PersonalDataManager* manager = GetManager();
   const std::vector<CreditCard*>& cards = manager->credit_cards();
   for (size_t i = 0; i < cards.size(); ++i) {
     suggested_cc_.AddItem(cards[i]->guid(), cards[i]->Label());
   }
   suggested_cc_.AddItem("", ASCIIToUTF16("Enter new card"));
 
   const std::vector<AutofillProfile*>& profiles = manager->GetProfiles();
   const std::string app_locale = AutofillCountry::ApplicationLocale();
   for (size_t i = 0; i < profiles.size(); ++i) {
+    // TODO(estade): deal with variants.
+    if (!IsCompleteProfile(*profiles[i]))
+      continue;
+
     string16 email = profiles[i]->GetInfo(EMAIL_ADDRESS, app_locale);
     if (!email.empty())
       suggested_email_.AddItem(profiles[i]->guid(), email);
     suggested_billing_.AddItem(profiles[i]->guid(), profiles[i]->Label());
     suggested_shipping_.AddItem(profiles[i]->guid(), profiles[i]->Label());
   }
   suggested_billing_.AddItem("", ASCIIToUTF16("Enter new billing"));
   suggested_email_.AddItem("", ASCIIToUTF16("Enter new email"));
   suggested_shipping_.AddItem("", ASCIIToUTF16("Enter new shipping"));
 }
 
+
+bool AutofillDialogController::IsCompleteProfile(
+    const AutofillProfile& profile) {
+  const std::string app_locale = AutofillCountry::ApplicationLocale();
+  for (size_t i = 0; i < requested_shipping_fields_.size(); ++i) {
+    if (profile.GetInfo(requested_shipping_fields_[i].type,
+                        app_locale).empty()) {
+      return false;
+    }
+  }
+
+  return true;
+}
+
 void AutofillDialogController::FillOutputForSectionWithComparator(
     DialogSection section, const InputFieldComparator& compare) {
   int suggestion_selection = view_->GetSuggestionSelection(section);
   SuggestionsComboboxModel* model = SuggestionsModelForSection(section);
   PersonalDataManager* manager = GetManager();
   if (suggestion_selection < model->GetItemCount() - 1) {
     std::string guid = model->GetItemKeyAt(suggestion_selection);
     FormGroup* form_group = section == SECTION_CC ?
         static_cast<FormGroup*>(manager->GetCreditCardByGUID(guid)) :
         static_cast<FormGroup*>(manager->GetProfileByGUID(guid));
@@ skipping 75 matching lines @@
 
   NOTREACHED();
   return NULL;
 }
 
 PersonalDataManager* AutofillDialogController::GetManager() {
   return PersonalDataManagerFactory::GetForProfile(profile_);
 }
 
 }  // namespace autofill