Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6514)

Unified Diff: chrome/common/extensions/extension.h

Issue 11742005: Move [Homepage,Options,Update,DevTools]URL out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_browser_action
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index b185d2c21eea763360baff8857edde7b1943fa57..4f440193bb7ad6781fd667592af41d24350a841b 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -540,11 +540,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// Whether context menu should be shown for page and browser actions.
bool ShowConfigureContextMenus() const;
- // Returns the Homepage URL for this extension. If homepage_url was not
- // specified in the manifest, this returns the Google Gallery URL. For
- // third-party extensions, this returns a blank GURL.
- GURL GetHomepageURL() const;
-
// Returns a list of paths (relative to the extension dir) for images that
// the browser might load (like themes and page action icons).
std::set<FilePath> GetBrowserImages() const;
@@ -718,8 +713,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool has_lazy_background_page() const {
return has_background_page() && !background_page_is_persistent_;
}
- const GURL& options_url() const { return options_url_; }
- const GURL& devtools_url() const { return devtools_url_; }
const GURL& details_url() const { return details_url_;}
const PermissionSet* optional_permission_set() const {
return optional_permission_set_.get();
@@ -733,7 +726,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
const InstallWarningVector& install_warnings() const {
return install_warnings_;
}
- const GURL& update_url() const { return update_url_; }
const ExtensionIconSet& icons() const { return icons_; }
const extensions::Manifest* manifest() const {
return manifest_.get();
@@ -882,8 +874,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
string16* error);
bool LoadDescription(string16* error);
bool LoadManifestVersion(string16* error);
- bool LoadHomepageURL(string16* error);
- bool LoadUpdateURL(string16* error);
bool LoadIcons(string16* error);
bool LoadCommands(string16* error);
bool LoadPlugins(string16* error);
@@ -894,7 +884,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadRequirements(string16* error);
bool LoadDefaultLocale(string16* error);
bool LoadOfflineEnabled(string16* error);
- bool LoadOptionsPage(string16* error);
bool LoadBackgroundScripts(string16* error);
bool LoadBackgroundScripts(const std::string& key, string16* error);
bool LoadBackgroundPage(const APIPermissionSet& api_permissions,
@@ -920,7 +909,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadExtensionFeatures(APIPermissionSet* api_permissions,
string16* error);
bool LoadManifestHandlerFeatures(string16* error);
- bool LoadDevToolsPage(string16* error);
bool LoadInputComponents(const APIPermissionSet& api_permissions,
string16* error);
bool LoadContentScripts(string16* error);
@@ -1116,12 +1104,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// allowing them to run in different processes.
bool allow_background_js_access_;
- // Optional URL to a page for setting options/preferences.
- GURL options_url_;
-
- // Optional URL to a devtools extension page.
- GURL devtools_url_;
-
// URL to the webstore page of the extension.
GURL details_url_;
@@ -1140,13 +1122,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// A map of display properties.
scoped_ptr<base::DictionaryValue> theme_display_properties_;
- // The homepage for this extension. Useful if it is not hosted by Google and
- // therefore does not have a Gallery URL.
- GURL homepage_url_;
-
- // URL for fetching an update manifest
- GURL update_url_;
-
// The manifest from which this extension was created.
scoped_ptr<Manifest> manifest_;
« no previous file with comments | « chrome/common/extensions/api/extension_urls/update_manifest_unittest.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698