Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 1174173007: Expand the class id to 32 bits and size field to 16 bits on 64-bit platforms. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_arm.cc
diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc
index 2914a50475bf88c3b7ac34ba52cdf66ff5dad681..5b9a6189558f70adf4de34e3d2a11d1f1c992137 100644
--- a/runtime/vm/intermediate_language_arm.cc
+++ b/runtime/vm/intermediate_language_arm.cc
@@ -1571,6 +1571,8 @@ LocationSummary* GuardFieldClassInstr::MakeLocationSummary(Zone* zone,
void GuardFieldClassInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+ ASSERT(sizeof(classid_t) == 2);
siva 2015/06/12 22:08:11 instead of 2 use kInt16Size
+
const intptr_t value_cid = value()->Type()->ToCid();
const intptr_t field_cid = field().guarded_cid();
const intptr_t nullability = field().is_nullable() ? kNullCid : kIllegalCid;
@@ -2034,6 +2036,8 @@ static void EnsureMutableBox(FlowGraphCompiler* compiler,
void StoreInstanceFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+ ASSERT(sizeof(classid_t) == 2);
+
Label skip_store;
const Register instance_reg = locs()->in(0).reg();
@@ -2427,6 +2431,8 @@ LocationSummary* LoadFieldInstr::MakeLocationSummary(Zone* zone,
void LoadFieldInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+ ASSERT(sizeof(classid_t) == 2);
+
const Register instance_reg = locs()->in(0).reg();
if (IsUnboxedLoad() && compiler->is_optimizing()) {
const DRegister result = EvenDRegisterOf(locs()->out(0).fpu_reg());

Powered by Google App Engine
This is Rietveld 408576698