Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 117413002: Revert of Disable two DomSerializerTests in preperation of page serializer merge (Closed)

Created:
7 years ago by Tiger
Modified:
7 years ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/115163002/ Reason for revert: Invalid. Doesn't disable the tests. TBR=abarth@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M content/renderer/dom_serializer_browsertest.cc View 2 chunks +2 lines, -11 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
Tiger
Created Revert of Disable two DomSerializerTests in preperation of page serializer merge
7 years ago (2013-12-17 16:32:52 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-17 16:33:36 UTC) #2
Tiger
On 2013/12/17 16:32:52, Tiger wrote: > Created Revert of Disable two DomSerializerTests in preperation of ...
7 years ago (2013-12-17 16:34:15 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-17 17:11:28 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/117413002/diff/1/content/renderer/dom_serializer_browsertest.cc File content/renderer/dom_serializer_browsertest.cc (left): https://codereview.chromium.org/117413002/diff/1/content/renderer/dom_serializer_browsertest.cc#oldcode915 content/renderer/dom_serializer_browsertest.cc:915: DISABLE_SerializeHTMLDOMWithEntitiesInAttributeValue) { ah, right. It should be DISABLED_ (with ...
7 years ago (2013-12-17 19:07:08 UTC) #5
Tiger
On 2013/12/17 19:07:08, jochen wrote: > https://codereview.chromium.org/117413002/diff/1/content/renderer/dom_serializer_browsertest.cc > File content/renderer/dom_serializer_browsertest.cc (left): > > https://codereview.chromium.org/117413002/diff/1/content/renderer/dom_serializer_browsertest.cc#oldcode915 > ...
7 years ago (2013-12-17 20:45:18 UTC) #6
Tiger
7 years ago (2013-12-17 20:57:58 UTC) #7
Message was sent while issue was closed.
On 2013/12/17 20:45:18, Tiger wrote:
> On 2013/12/17 19:07:08, jochen wrote:
> >
>
https://codereview.chromium.org/117413002/diff/1/content/renderer/dom_seriali...
> > File content/renderer/dom_serializer_browsertest.cc (left):
> > 
> >
>
https://codereview.chromium.org/117413002/diff/1/content/renderer/dom_seriali...
> > content/renderer/dom_serializer_browsertest.cc:915:
> > DISABLE_SerializeHTMLDOMWithEntitiesInAttributeValue) {
> > ah, right. It should be DISABLED_ (with a D)
> > 
> > can you fix that instead of reverting, or don't you need those anymore?
> 
> Sure, I haven't merged the serializer merge yet though, so it should be no
> problem either way. Still need the disabling.

Moved to a new CL instead: https://codereview.chromium.org/106023004/

Powered by Google App Engine
This is Rietveld 408576698