chrome/browser/notifications/notification_prefs_manager.cc - Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_prefs_manager.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to review comments. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/pref_proxy_config_tracker_impl_unittest.cc ('K') | « chrome/browser/notifications/notification_prefs_manager.h ('k') | chrome/browser/plugins/plugin_finder.h » ('j') | chrome/browser/prefs/browser_prefs.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_prefs_manager.cc

diff --git a/chrome/browser/notifications/notification_prefs_manager.cc b/chrome/browser/notifications/notification_prefs_manager.cc

index 01928aac1617c7f82e8b05697aae94fc076216c7..a01f337a147669806ab7c6f1939cb66b1a79d8da 100644

--- a/chrome/browser/notifications/notification_prefs_manager.cc

+++ b/chrome/browser/notifications/notification_prefs_manager.cc

@@ -4,13 +4,15 @@

#include "chrome/browser/notifications/notification_prefs_manager.h"

+#include "chrome/browser/prefs/pref_registry_simple.h"

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/common/pref_names.h"

// static

-void NotificationPrefsManager::RegisterPrefs(PrefServiceSimple* prefs) {

- prefs->RegisterIntegerPref(prefs::kDesktopNotificationPosition,

- BalloonCollection::DEFAULT_POSITION);

+void NotificationPrefsManager::RegisterPrefs(PrefService* prefs,

+ PrefRegistrySimple* registry) {

+ registry->RegisterIntegerPref(prefs::kDesktopNotificationPosition,

+ BalloonCollection::DEFAULT_POSITION);

#if defined(OS_CHROMEOS)

Mattias Nissler (ping if slow) 2013/01/31 13:06:25 Add a TODO saying that we shouldn't do this here?

Jói 2013/01/31 13:43:42 Done.

// Option menu for changing desktop notification position on ChromeOS is

// disabled. Force preference to default.