chrome/browser/notifications/notification_prefs_manager.cc - Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/notifications/notification_prefs_manager.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to review comments. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/net/pref_proxy_config_tracker_impl_unittest.cc ('K') | « chrome/browser/notifications/notification_prefs_manager.h ('k') | chrome/browser/plugins/plugin_finder.h » ('j') | chrome/browser/prefs/browser_prefs.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/notifications/notification_prefs_manager.h"	5 #include "chrome/browser/notifications/notification_prefs_manager.h"

6	6

	7 #include "chrome/browser/prefs/pref_registry_simple.h"

7 #include "chrome/browser/prefs/pref_service.h"	8 #include "chrome/browser/prefs/pref_service.h"

8 #include "chrome/common/pref_names.h"	9 #include "chrome/common/pref_names.h"

9	10

10 // static	11 // static

11 void NotificationPrefsManager::RegisterPrefs(PrefServiceSimple* prefs) {	12 void NotificationPrefsManager::RegisterPrefs(PrefService* prefs,

12 prefs->RegisterIntegerPref(prefs::kDesktopNotificationPosition,	13 PrefRegistrySimple* registry) {

13 BalloonCollection::DEFAULT_POSITION);	14 registry->RegisterIntegerPref(prefs::kDesktopNotificationPosition,

	15 BalloonCollection::DEFAULT_POSITION);

14 #if defined(OS_CHROMEOS)	16 #if defined(OS_CHROMEOS)
	Mattias Nissler (ping if slow) 2013/01/31 13:06:25 Add a TODO saying that we shouldn't do this here? Add a TODO saying that we shouldn't do this here? Jói 2013/01/31 13:43:42 Done. Show quoted text On 2013/01/31 13:06:25, Mattias Nissler wrote: > Add a TODO saying that we shouldn't do this here? Done.
15 // Option menu for changing desktop notification position on ChromeOS is	17 // Option menu for changing desktop notification position on ChromeOS is

16 // disabled. Force preference to default.	18 // disabled. Force preference to default.

17 prefs->SetInteger(prefs::kDesktopNotificationPosition,	19 prefs->SetInteger(prefs::kDesktopNotificationPosition,

18 BalloonCollection::DEFAULT_POSITION);	20 BalloonCollection::DEFAULT_POSITION);

19 #endif	21 #endif

20 }	22 }

OLD	NEW