chrome/chrome_browser.gypi - Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Fix Clang build and fix bug shown by trybots. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/web_resource/promo_resource_service.cc ('K') | « chrome/browser/web_resource/promo_resource_service.cc ('k') | chrome/test/base/testing_browser_process.h » ('j') | chrome/test/base/testing_pref_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index cc3bd0e83cf5c8ccbebd4ba990fd1a269d9e3f1a..fc7e2912414311938763d7e0526cf7f53f49a064 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1482,12 +1482,14 @@

'browser/prefs/pref_model_associator.h',

'browser/prefs/pref_notifier_impl.cc',

'browser/prefs/pref_notifier_impl.h',

+ 'browser/prefs/pref_registry.cc',

+ 'browser/prefs/pref_registry.h',

+ 'browser/prefs/pref_registry_simple.cc',

+ 'browser/prefs/pref_registry_simple.h',

'browser/prefs/pref_service.cc',

'browser/prefs/pref_service.h',

'browser/prefs/pref_service_builder.cc',

'browser/prefs/pref_service_builder.h',

- 'browser/prefs/pref_service_simple.cc',

- 'browser/prefs/pref_service_simple.h',

'browser/prefs/pref_service_syncable.cc',

'browser/prefs/pref_service_syncable.h',

'browser/prefs/pref_service_syncable_builder.cc',